ActionMailerCheck: Support :sendmail and :test #21
+55
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for checking that the `sendmail` binary chosen is executable when ActionMailer is using the `:sendmail` delivery_method, and stubs out the check when using the `:test` delivery_method.
awilfox
force-pushed
the
awilfox/add-more-mailer-checks
branch
from
11d61cf to
9888f9a
Compare
awilfox
added a commit
to BerkeleyLibrary/framework
that referenced
this pull request
Dec 1, 2025
* The Alma patron fetch has been converted to a custom check. * ActionMailer is checked for connectivity. Note that this won't pass until emmahsax/okcomputer#21 is merged, because the `:test` delivery method isn't recognised for the ActionMailer check. Once it is merged, we can update the Gemfile to use the new version and then the tests will pass. Ref: AP-508
awilfox
added a commit
to BerkeleyLibrary/framework
that referenced
this pull request
Dec 1, 2025
* The Alma patron fetch has been converted to a custom check. * ActionMailer is checked for connectivity. Note that this won't pass until emmahsax/okcomputer#21 is merged, because the `:test` delivery method isn't recognised for the ActionMailer check. Once it is merged, we can update the Gemfile to use the new version and then the tests will pass. Ref: AP-508
awilfox
added a commit
to BerkeleyLibrary/framework
that referenced
this pull request
Dec 2, 2025
* The Alma patron fetch has been converted to a custom check. * ActionMailer is checked for connectivity. Note that this won't pass until emmahsax/okcomputer#21 is merged, because the `:test` delivery method isn't recognised for the ActionMailer check. Once it is merged, we can update the Gemfile to use the new version and then the tests will pass. Ref: AP-508
awilfox
added a commit
to BerkeleyLibrary/framework
that referenced
this pull request
Dec 2, 2025
* The Alma patron fetch has been converted to a custom check. * ActionMailer is checked for connectivity. Note that this won't pass until emmahsax/okcomputer#21 is merged, because the `:test` delivery method isn't recognised for the ActionMailer check. Once it is merged, we can update the Gemfile to use the new version and then the tests will pass. Ref: AP-508
awilfox
added a commit
to BerkeleyLibrary/framework
that referenced
this pull request
Dec 3, 2025
* The Alma patron fetch has been converted to a custom check. * ActionMailer is checked for connectivity. Note that the test is marked pending until emmahsax/okcomputer#21 is merged, because the `:test` delivery method isn't recognised for the ActionMailer check. Once it is merged, we can update the Gemfile to use the new version and then the tests will pass. Ref: AP-508
Owner
|
@awilfox I am having trouble getting this PR to trigger the tests. Can you try making another commit to the PR and maybe I'll be able to trigger them. EDIT: I managed to trigger them. |
Owner
|
@awilfox I have addressed the tests in my latest PR that I merged. Can you sync your fork with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for checking that the
sendmailbinary chosen is executable when ActionMailer is using the:sendmaildelivery_method, and stubs out the check when using the:testdelivery_method.My original goal with this change was to make sure OKComputer was successful during RSpec tests for both RapidRetail and BerkeleyLibrary/framework, of which I am adding OKComputer checks to both and seeing RSpec failures when using the ActionMailer check. I realised
:sendmailwould be pretty simple to check too, so I added that as well.This does not add support for
:file, but I can add it if desired.